Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in image reference commit id #3284

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Fixed typo in image reference commit id #3284

merged 1 commit into from
Nov 11, 2022

Conversation

sivarajans
Copy link
Contributor

Description

There was a typo in commit id reference in document

gep13
gep13 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Nov 11, 2022

@sivarajans wow! That is a great find! Thanks for catching that!

@asbjornu asbjornu changed the base branch from main to support/5.x November 11, 2022 08:38
@asbjornu
Copy link
Member

I think this is something we should do for v5, so I tried changing the base branch from main to support/5.x, but that of course needs a proper rebase. Are you able to do that @sivarajans? If not, I'll cherry-pick 248b901 into a new PR.

@sivarajans
Copy link
Contributor Author

sivarajans commented Nov 11, 2022 •
edited
Loading

I think this is something we should do for v5, so I tried changing the base branch from main to support/5.x, but that of course needs a proper rebase. Are you able to do that @sivarajans? If not, I'll cherry-pick 248b901 into a new PR.

Let me fix this

@sivarajans
Copy link
Contributor Author

@asbjornu I have updated to feed this change to support/5.x branch.

@asbjornu
Copy link
Member

@sivarajans, awesome! Thanks! 🙏🏼

@asbjornu asbjornu merged commit 552710f into GitTools:support/5.x Nov 11, 2022
@asbjornu asbjornu added this to the 5.x milestone Nov 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2022

Thank you @sivarajans for your contribution!

arturcic pushed a commit that referenced this pull request Nov 11, 2022
@web-flow
Continuous Integration Publish: 552710f
b2b9378 
Merge pull request #3284 from sivarajans/patch-typo-fix

Fixed typo in image reference commit id
@arturcic arturcic modified the milestones: 5.x, 6.x, 6.0.0-alpha.1 Dec 19, 2022
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
6.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.
4 participants
@sivarajans @gep13 @asbjornu @arturcic